Add support for Registration Tokens by shweta83 · Pull Request #17555 · SatelliteQE/robottelo

shweta83 · 2025-02-09T18:44:30Z

Problem Statement

Add support for JWT invalidate via API: SAT-30383

Solution

Added API support

Related Issues

SatelliteQE/nailgun#1260

shweta83 · 2025-02-09T18:46:20Z

trigger: test-robottelo
pytest: tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-09T19:09:54Z

PRT Result

Build Number: 10133
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ========= 2 passed, 148 deselected, 256 warnings in 1050.83s (0:17:30) =========

tests/foreman/api/test_user.py

shweta83 · 2025-02-10T14:35:21Z

trigger: test-robottelo
pytest: tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens
nailgun: 1260

shweta83 · 2025-02-10T14:38:26Z

trigger: test-robottelo
pytest: tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-10T15:04:32Z

PRT Result

Build Number: 10139
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ========= 2 passed, 148 deselected, 257 warnings in 996.42s (0:16:36) ==========

shweta83 · 2025-02-10T18:25:05Z

trigger: test-robottelo
pytest: tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-10T18:50:34Z

PRT Result

Build Number: 10140
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ==== 2 passed, 148 deselected, 261 warnings, 1 error in 1072.12s (0:17:52) =====

Satellite-QE · 2025-02-10T19:18:32Z

PRT Result

Build Number: 10142
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ===== 2 passed, 148 deselected, 257 warnings, 1 error in 997.23s (0:16:37) =====

chris1984

Looks straight forward

tests/foreman/api/test_user.py

shweta83 · 2025-02-12T06:56:42Z

trigger: test-robottelo
pytest: tests/foreman/api/test_user.py -k test_positive_invalidate_users_tokens
nailgun: 1260

shweta83 · 2025-02-12T14:20:29Z

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-12T14:44:40Z

PRT Result

Build Number: 10151
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ===== 1 passed, 23 deselected, 36 warnings, 1 error in 1023.36s (0:17:03) ======

tests/foreman/api/test_registration.py

Gauravtalreja1 · 2025-02-12T20:15:28Z

tests/foreman/api/test_registration.py

+    user = admin_user
+
+    # Non-Admin user with "edit_users" permission and "Register hosts" role
+    roles = [target_sat.api.Role().create()]


Optional: It would be better to define it as a custom_role and assign permissions then append it to list or you simply add to the list when creating a user along with host_register_role

I would like to keep this.

tests/foreman/api/test_registration.py

shweta83 · 2025-02-13T05:04:32Z

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-13T05:41:26Z

PRT Result

Build Number: 10156
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ===== 1 passed, 23 deselected, 36 warnings, 1 error in 1696.73s (0:28:16) ======

shweta83 · 2025-02-13T05:50:17Z

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens
nailgun: 1260

Satellite-QE · 2025-02-13T06:19:58Z

PRT Result

Build Number: 10157
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py -k test_positive_invalidate_users_tokens --external-logging
Test Result : ========== 1 passed, 23 deselected, 36 warnings in 1328.80s (0:22:08) ==========

Gauravtalreja1

ACK, @shweta83 Good job and thanks for addressing the comments

shweta83 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Feb 9, 2025

shweta83 requested a review from a team as a code owner February 9, 2025 18:44

github-actions bot assigned shweta83 Feb 9, 2025

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 9, 2025

shweta83 requested a review from a team February 10, 2025 05:09

shweta83 mentioned this pull request Feb 10, 2025

Add support for Registration Tokens SatelliteQE/nailgun#1260

Merged

shweta83 requested a review from girijaasoni February 10, 2025 05:23

amolpati30 requested changes Feb 10, 2025

View reviewed changes

tests/foreman/api/test_user.py Outdated Show resolved Hide resolved

amolpati30 requested changes Feb 10, 2025

View reviewed changes

tests/foreman/api/test_user.py Outdated Show resolved Hide resolved

shweta83 force-pushed the jwt_invalidate_api_support branch from 444794d to d0dd9b9 Compare February 10, 2025 14:34

shweta83 requested review from Gauravtalreja1 and amolpati30 February 10, 2025 14:34

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 10, 2025

shweta83 force-pushed the jwt_invalidate_api_support branch from d0dd9b9 to b10038a Compare February 10, 2025 14:36

Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 10, 2025

amolpati30 approved these changes Feb 10, 2025

View reviewed changes

shweta83 force-pushed the jwt_invalidate_api_support branch from b10038a to 6309f7c Compare February 10, 2025 18:16

Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 10, 2025

shweta83 force-pushed the jwt_invalidate_api_support branch from 6309f7c to b142abd Compare February 10, 2025 18:23

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 10, 2025

chris1984 approved these changes Feb 10, 2025

View reviewed changes

shweta83 force-pushed the jwt_invalidate_api_support branch from b142abd to 67c4ca1 Compare February 11, 2025 06:59

shubhamsg199 approved these changes Feb 11, 2025

View reviewed changes

Gauravtalreja1 requested changes Feb 11, 2025

View reviewed changes

tests/foreman/api/test_user.py Outdated Show resolved Hide resolved

Gauravtalreja1 added the API Issues and PRs involving the API label Feb 11, 2025

shweta83 force-pushed the jwt_invalidate_api_support branch 2 times, most recently from 9dcf9ee to dac6697 Compare February 11, 2025 17:30

shweta83 requested a review from Gauravtalreja1 February 12, 2025 04:36

Gauravtalreja1 reviewed Feb 12, 2025

View reviewed changes

shweta83 force-pushed the jwt_invalidate_api_support branch 2 times, most recently from d5ea2a4 to 4863186 Compare February 13, 2025 05:02

Add support for Registration Tokens

f5e163a

shweta83 force-pushed the jwt_invalidate_api_support branch from 4863186 to f5e163a Compare February 13, 2025 05:50

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 13, 2025

shweta83 requested a review from Gauravtalreja1 February 13, 2025 07:56

Gauravtalreja1 approved these changes Feb 13, 2025

View reviewed changes

Gauravtalreja1 merged commit 03a11c7 into SatelliteQE:master Feb 13, 2025
12 checks passed

Conversation

shweta83 commented Feb 9, 2025

Problem Statement

Solution

Related Issues

Uh oh!

shweta83 commented Feb 9, 2025

Uh oh!

Satellite-QE commented Feb 9, 2025

Uh oh!

Uh oh!

Uh oh!

shweta83 commented Feb 10, 2025

Uh oh!

shweta83 commented Feb 10, 2025

Uh oh!

Satellite-QE commented Feb 10, 2025

Uh oh!

shweta83 commented Feb 10, 2025

Uh oh!

Satellite-QE commented Feb 10, 2025

Uh oh!

Satellite-QE commented Feb 10, 2025

Uh oh!

chris1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shweta83 commented Feb 12, 2025

Uh oh!

shweta83 commented Feb 12, 2025

Uh oh!

Satellite-QE commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gauravtalreja1 Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

shweta83 Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shweta83 commented Feb 13, 2025

Uh oh!

Satellite-QE commented Feb 13, 2025

Uh oh!

shweta83 commented Feb 13, 2025

Uh oh!

Satellite-QE commented Feb 13, 2025

Uh oh!

Gauravtalreja1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants